Skip to content

Commit

Permalink
feat(common.cookie): allow usage of secrets for header
Browse files Browse the repository at this point in the history
  • Loading branch information
ZPascal committed Jul 19, 2024
1 parent 41553ff commit 972e5a7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
14 changes: 11 additions & 3 deletions plugins/common/cookie/cookie.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type CookieAuthConfig struct {
URL string `toml:"cookie_auth_url"`
Method string `toml:"cookie_auth_method"`

Headers map[string]string `toml:"cookie_auth_headers"`
Headers map[string]*config.Secret `toml:"cookie_auth_headers"`

// HTTP Basic Auth Credentials
Username string `toml:"cookie_auth_username"`
Expand Down Expand Up @@ -98,11 +98,19 @@ func (c *CookieAuthConfig) auth() error {
}

for k, v := range c.Headers {
secret, err := v.Get()
if err != nil {
return err
}

headerVal := secret.String()
if strings.EqualFold(k, "host") {
req.Host = v
req.Host = headerVal
} else {
req.Header.Add(k, v)
req.Header.Add(k, headerVal)
}

secret.Destroy()
}

resp, err := c.client.Do(req)
Expand Down
6 changes: 4 additions & 2 deletions plugins/common/cookie/cookie_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ var fakeCookie = &http.Cookie{
Value: "this is an auth cookie",
}

var reqHeaderValSecret = config.NewSecret([]byte(reqHeaderVal))

type fakeServer struct {
*httptest.Server
*int32
Expand Down Expand Up @@ -123,7 +125,7 @@ func TestAuthConfig_Start(t *testing.T) {
Username string
Password string
Body string
Headers map[string]string
Headers map[string]*config.Secret
}
type args struct {
renewal time.Duration
Expand Down Expand Up @@ -157,7 +159,7 @@ func TestAuthConfig_Start(t *testing.T) {
endpoint: authEndpointWithHeader,
},
fields: fields{
Headers: map[string]string{reqHeaderKey: reqHeaderVal},
Headers: map[string]*config.Secret{reqHeaderKey: &reqHeaderValSecret},
},
firstAuthCount: 1,
lastAuthCount: 3,
Expand Down

0 comments on commit 972e5a7

Please sign in to comment.