Skip to content

Commit

Permalink
Add redis_version field to redis input (#3054)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielnelson authored Jul 26, 2017
1 parent ffd1f25 commit 83f575f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions plugins/inputs/redis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Additionally the plugin also calculates the hit/miss ratio (keyspace\_hitrate) a
**Server**
- uptime(int, seconds)
- lru_clock(int, number)
- redis_version(string)

**Clients**
- clients(int, number)
Expand Down
2 changes: 1 addition & 1 deletion plugins/inputs/redis/redis.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func gatherInfoOutput(
name := string(parts[0])

if section == "Server" {
if name != "lru_clock" && name != "uptime_in_seconds" {
if name != "lru_clock" && name != "uptime_in_seconds" && name != "redis_version" {
continue
}
}
Expand Down
1 change: 1 addition & 0 deletions plugins/inputs/redis/redis_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ func TestRedis_ParseMetrics(t *testing.T) {
"used_cpu_sys_children": float64(0.00),
"used_cpu_user_children": float64(0.00),
"keyspace_hitrate": float64(0.50),
"redis_version": "2.8.9",
}

// We have to test rdb_last_save_time_offset manually because the value is based on the time when gathered
Expand Down

0 comments on commit 83f575f

Please sign in to comment.