chore: Forbids "log" package only for aggregators, inputs, outputs, p…

…arsers and processors (#10191) Co-authored-by: Pawel Zak <Pawel Zak> (cherry picked from commit 1143a50)
influxdata · Dec 8, 2021 · 47fa0fa · 47fa0fa
1 parent 8d65717
commit 47fa0fa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -126,5 +126,10 @@ issues:
     - path: _test\.go
       text: "parameter.*seems to be a control flag, avoid control coupling"
 
+    - path: (^agent/|^cmd/|^config/|^filter/|^internal/|^logger/|^metric/|^models/|^selfstat/|^testutil/|^plugins/serializers/)
+      text: "imports-blacklist: should not use the following blacklisted import: \"log\""
+      linters:
+        - revive
+
 output:
   format: tab
diff --git a/plugins/common/logrus/hook.go b/plugins/common/logrus/hook.go
@@ -2,7 +2,7 @@ package logrus
 
 import (
 	"io"
-	"log"
+	"log" //nolint:revive // Allow exceptional but valid use of log here.
 	"strings"
 	"sync"
 

diff --git a/plugins/common/shim/config.go b/plugins/common/shim/config.go
@@ -3,7 +3,7 @@ package shim
 import (
 	"errors"
 	"fmt"
-	"log"
+	"log" //nolint:revive // Allow exceptional but valid use of log here.
 	"os"
 
 	"github.com/BurntSushi/toml"

diff --git a/plugins/common/shim/logger.go b/plugins/common/shim/logger.go
@@ -2,7 +2,7 @@ package shim
 
 import (
 	"fmt"
-	"log"
+	"log" //nolint:revive // Allow exceptional but valid use of log here.
 	"os"
 	"reflect"
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,7 @@ package logrus @@
     import (
     	"io"
-    	"log"
+    	"log" //nolint:revive // Allow exceptional but valid use of log here.
     	"strings"
     	"sync"
@@ Expand Down @@