fix: remove dependency on protoc in pbjson-types #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves pbjson-type's code generation to a manual executable instead of build.rs. Now the generated files are checked into the repo, and users do not need
protoc
to build the pbjson-types crate.This has a slight drawback in that pbjson developers will need to invoke the generator manually after any relevant code-gen changes. This should generally be a worthwhile tradeoff, as several users have encountered trouble with requiring protoc (see #62).
That drawback could potentially be averted with some CI steps to run the generator and check-in the code automatically; this change does not include such automation however.