Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya!
Thanks for the great work in making it easier to switch between protobuf and json / other serde encodings. I recently ran into an issue where I had to use the
prost_types::Any
type though. Prost's any provides some nice methods for going to and fromprost::Message
's, but they require the trait boundprost::Name
. Name is not implemented on prost-generated types by default, but this can trivially be opted into by called.enable_type_names()
on the config. An even more ergonomic change would be to also implementfrom_msg
andto_msg
onpbjson_types::Any
, but simply derivingprost::Name
on all the standard types atleast lets the end user use prost's Any by shuffing around the structs a bit.Before merging, I believe a few things should be settled:
from_msg
andto_msg
onpbjson_types::Any