Add X-Influxdb-Build value to HTTP response header #8574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-rushakoff
approved these changes
Jul 6, 2017
aanthony1243
force-pushed
the
plutonium#1240_master
branch
from
b22ad45 to
f682ca1
Compare
e-dard
previously approved these changes
Jul 7, 2017
e-dard
suggested changes
Jul 7, 2017
CHANGELOG.md
Outdated
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| ### Features | |||
|
|
|||
| - [plutonium#1240](https://github.com/influxdata/plutonium/issues/1240): Add 'X-Influxdb-Build' to http response headers so users can identify if a response is from an OSS or Enterprise service. | |||
There was a problem hiding this comment.
This should be an influxdata/influxdb issue if there is one available, or if there isn't then it's usual for us to just link to this PR, e.g.,
[#8574](https://github.com/influxdata/influxdb/pull/8574): Add 'X-Influxdb-Build' to HTTP response headers so users can identify if a response is from an OSS or Enterprise service.
…lled from open-source build, and ENT if called from enterprise. This commit sets the value for the OSS case, and also creates the proper flag
aanthony1243
force-pushed
the
plutonium#1240_master
branch
from
1b62e1f to
2259ada
Compare
e-dard
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new header key/value X-Influxdb-Build that has value OSS if called from open-source build, and ENT if called from enterprise. This commit sets the value for the OSS case, and also creates the proper flag
Required for all non-trivial PRs
Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.