fix: fixes bug with authorizer leakage in show queries (#27196)#27197
Merged
fix: fixes bug with authorizer leakage in show queries (#27196)#27197
Conversation
This PR fixes and authorization leak when running `SHOW QUERIES` as a user with access to the database you are using. Previously non-admin users could run `SHOW QUERIES` on DBs they owned, but, there was no filtering to stop them from seeing queries on other dbs too: ``` # as admin > CREATE USER bar WITH PASSWORD 'password' > GRANT ALL on "mydb" TO "bar" # as 'bar' user > SHOW QUERIES ERR: error authorizing query: bar not authorized to execute statement 'SHOW QUERIES', requires READ on > use mydb Using database mydb > SHOW QUERIES qid query database duration status --- ----- -------- -------- ------ 31 SELECT * FROM actions foobar 585ms running # this wasn't granted to 'bar'!! 32 SHOW QUERIES mydb 15µs running ``` (cherry picked from commit 5778e07)
davidby-influx
approved these changes
Feb 6, 2026
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
LGTM as a cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes and authorization leak when running
SHOW QUERIESas a user with access to the database you are using.Previously non-admin users could run
SHOW QUERIESon DBs they owned, but, there was no filtering to stop them from seeing queries on other dbs too:(cherry picked from commit 5778e07)