fix: enable HttpOnly and Secure using TLS #24524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TLS is enabled, set the HttpOnly and Secure flags when a cookie is created. closes: #24522
davidby-influx
added
security
kind/bug
area/api
area/2.x
jeffreyssmith2nd
approved these changes
Dec 20, 2023
jdstrand
reviewed
Dec 20, 2023
session/http_server.go
Outdated
| @@ -208,6 +208,8 @@ func encodeCookieSession(w http.ResponseWriter, s *influxdb.Session) { | |||
| Path: "/api/", // since UI doesn't need it, limit cookie usage to API requests | |||
| Expires: s.ExpiresAt, | |||
| SameSite: http.SameSiteStrictMode, | |||
| HttpOnly: tlsEnabled, | |||
There was a problem hiding this comment.
Thanks for the patch! HttpOnly should be set regardless of tlsEnabled (we can still help guard against XSS when not using TLS after all).
davidby-influx
added a commit
that referenced
this pull request
Dec 20, 2023
davidby-influx
added a commit
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TLS is enabled, set the HttpOnly and
Secure flags when a cookie is created.
closes: #24522