Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Task concurrency not being respected #23881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

redaianer
Copy link

Description

There is already a limit function (ConcurrencyLimit()) to limit the count of concurrent runs of a task, but these function was never attached to the executor, so setting these limit won't work.
The fix sets the limit function on task executor creation.

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

@redaianer redaianer changed the title fix: Task concurrency not being respected #23582 fix: Task concurrency not being respected Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task concurrency not being respected
1 participant