build(flux): update flux to v0.117.0 #21539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
reviewed
May 24, 2021
| @@ -12,6 +12,7 @@ import ( | |||
| _ "github.com/mna/pigeon" | |||
| _ "golang.org/x/tools/cmd/goimports" | |||
| _ "golang.org/x/tools/cmd/stringer" | |||
| _ "gopkg.in/yaml.v2" | |||
There was a problem hiding this comment.
There was a test called influxql_validation that was failing:
https://app.circleci.com/pipelines/github/influxdata/influxdb/20730/workflows/b6570808-a0f1-478e-8f7f-2f95fd6b02ca/jobs/191747
Apparently this test needs this dependency, but it's not kept around by go mod tidy, and it can't be added as the test runs due to -mod=readonly. I added it to tools.go so that there is an explicit dependency. We've used this mechanism in the past in order to pin to versions of packages that are not necessarily used from Go code explicitly.
Is there a better way to address this?
There was a problem hiding this comment.
Nah that makes sense to me 👍 I was just curious
danxmoran
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.