feat(cmd/influx): support reading GZIP data in influx write
#20763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Feb 16, 2021
|
|
danxmoran
force-pushed
the
dm-influx-write-gzip-20659
branch
from
a479caa to
20bc5f7
Compare
lesam
reviewed
Feb 18, 2021
lesam
reviewed
Feb 18, 2021
danxmoran
commented
Feb 18, 2021
danxmoran
force-pushed
the
dm-influx-write-gzip-20659
branch
from
d859fd6 to
9cabd54
Compare
lesam
reviewed
Feb 19, 2021
cmd/influx/write.go
Outdated
|
|
||
| compressed := b.Compression == "gzip" || (len(b.Compression) == 0 && strings.HasSuffix(file, ".gz")) | ||
| if compressed { | ||
| file = strings.TrimSuffix(file, ".gz") |
There was a problem hiding this comment.
As a user I would prefer to see the .gz suffix in the error message. Not blocking.
Untested preliminary code for a hand-off of the work. Part of https://github.com/influxdata/influxdb/issues/20462
danxmoran
force-pushed
the
dm-influx-write-gzip-20659
branch
from
9cabd54 to
bbcd966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20659
This is meant to mirror the implementation of the existing CSV support.
.gzenable decompressionContent-Encoding: gzipenable decompressionUnlike the existing CSV impl, gzip-or-not is handled on an input-by-input basis when the CLI option isn't set.