Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): make envRef default values support more types #19116

Merged
merged 1 commit into from
Jul 28, 2020
Merged

feat(pkger): make envRef default values support more types #19116

merged 1 commit into from
Jul 28, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jul 28, 2020 •
edited
Loading

this change removes implicit default values from env refs returned via the API. All default values moving forward will have to be explicity provided via the template. The magical env-ENVREFKEY thing is finally going away. This work is in support of query parameterizations which will follow this.

references: #18237

@jsteenb2 jsteenb2 requested a review from a team as a code owner July 28, 2020 18:31
@jsteenb2 jsteenb2 requested review from imogenkinsman and removed request for a team July 28, 2020 18:31
@jsteenb2 jsteenb2 force-pushed the 18237/template_query_parameteriation branch from a745bf0 to 976adf4 Compare July 28, 2020 18:34
@jsteenb2 jsteenb2 requested a review from a team as a code owner July 28, 2020 18:34
@jsteenb2 jsteenb2 requested review from hoorayimhelping and removed request for a team July 28, 2020 18:34
@jsteenb2 jsteenb2 force-pushed the 18237/template_query_parameteriation branch 2 times, most recently from 8614a1b to b5169f4 Compare July 28, 2020 18:37
@jsteenb2 jsteenb2 force-pushed the 18237/template_query_parameteriation branch 2 times, most recently from fe6dc69 to 2d84c9e Compare July 28, 2020 19:06
@jsteenb2 jsteenb2 force-pushed the 18237/template_query_parameteriation branch from 2d84c9e to 42019fa Compare July 28, 2020 19:09
@jsteenb2 jsteenb2 merged commit d768132 into master Jul 28, 2020
@jsteenb2 jsteenb2 deleted the 18237/template_query_parameteriation branch July 28, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@imogenkinsman imogenkinsman Awaiting requested review from imogenkinsman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsteenb2 @hoorayimhelping