feat(ui): Enhance resource creation experience when limits are reached #19103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
changed the title
mavarius
force-pushed
the
feat/create-resource-buttons
branch
from
95c948e to
6059f93
Compare
mavarius
changed the title
|
Just wanna say how great an enhancement this is |
ebb-tide
reviewed
Jul 30, 2020
ebb-tide
reviewed
Jul 30, 2020
ebb-tide
reviewed
Jul 30, 2020
ebb-tide
reviewed
Jul 30, 2020
| export const extractRulesMax = (limits: LimitsState): number => { | ||
| return get(limits, 'rules.maxAllowed') || Infinity | ||
| } | ||
| export const extractBlockedRules = (limits: LimitsState): string[] => { | ||
| return get(limits, 'rules.blocked') || [] | ||
| } | ||
|
|
||
| export const extractEndpointsLimits = (limits: LimitsState): LimitStatus => { | ||
| return get(limits, 'endpoints.limitStatus') |
There was a problem hiding this comment.
should these return some defaults?
There was a problem hiding this comment.
I don't think so. The defaults are set to LimitStatus.OK so there's always a value when these gets are called.
ebb-tide
reviewed
Jul 30, 2020
ebb-tide
reviewed
Jul 30, 2020
| @@ -13,6 +13,7 @@ export type OverlayID = | |||
| | 'telegraf-output' | |||
| | 'switch-organizations' | |||
| | 'create-bucket' | |||
| | 'asset-limit' | |||
|
|
|||
| export interface OverlayParams { | |||
| [key: string]: string | |||
There was a problem hiding this comment.
I really don't like that these params are actually required for the overlay to load properly, but they are not properly typed. I know you didn't write this, and I don't think you need to fix this in this PR, but it makes me worry :(
There was a problem hiding this comment.
Maybe we should open another tech debt issue for this.
ebb-tide
reviewed
Jul 30, 2020
ebb-tide
approved these changes
Jul 30, 2020
mavarius
force-pushed
the
feat/create-resource-buttons
branch
from
6059f93 to
d715fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change rate-limited create asset experience.
OLD EXPERIENCE
Create asset button disabled when asset limit is reached for Dashboards, Tasks, & Buckets
Trying to create a Check fails with an error after going though the process of configuring it
Trying to create a Rule fails silently with only a console error
NEW EXPERIENCE
Create asset button is always enabled
When user clicks to create asset they are presented with an upgrade overlay
