Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): extend template diff types with kind #18818

Merged
merged 1 commit into from
Jul 1, 2020
Merged

feat(pkger): extend template diff types with kind #18818

merged 1 commit into from
Jul 1, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jun 30, 2020 •
edited
Loading

note: ignore whitespaces 😬

closes: #18804

@jsteenb2 jsteenb2 requested a review from hoorayimhelping June 30, 2020 23:59
@jsteenb2 jsteenb2 requested review from a team as code owners June 30, 2020 23:59
@jsteenb2 jsteenb2 requested review from imogenkinsman and removed request for a team June 30, 2020 23:59
@jsteenb2 jsteenb2 force-pushed the 18804/pkger_extend_impact_types branch from cbbec1c to c0d51a8 Compare July 1, 2020 00:01
hoorayimhelping
hoorayimhelping approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot! super fast turnaround time

@jsteenb2 jsteenb2 force-pushed the 18804/pkger_extend_impact_types branch from c0d51a8 to 0bc4583 Compare July 1, 2020 00:07
@jsteenb2 jsteenb2 merged commit e851228 into master Jul 1, 2020
@jsteenb2 jsteenb2 deleted the 18804/pkger_extend_impact_types branch July 1, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@imogenkinsman imogenkinsman Awaiting requested review from imogenkinsman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Diff and Summary objects with resource Kinds
2 participants
@jsteenb2 @hoorayimhelping