Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): planner rule to push down window and bare first() and la… #18534

Merged
merged 2 commits into from
Jun 17, 2020
Merged

feat(query): planner rule to push down window and bare first() and la… #18534

merged 2 commits into from
Jun 17, 2020

Conversation

ethanyzhang
Copy link
Contributor

No description provided.

@ethanyzhang ethanyzhang requested a review from jacobmarble as a code owner June 16, 2020 14:56
@ethanyzhang ethanyzhang requested review from a team, adrian-thurston and jpacik and removed request for a team June 16, 2020 14:58
jpacik
jpacik reviewed Jun 16, 2020
View reviewed changes
Copy link
Contributor

@jpacik jpacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor nits.

flags.yml Show resolved Hide resolved
query/stdlib/influxdata/influxdb/rules_test.go Outdated Show resolved Hide resolved
@ethanyzhang ethanyzhang self-assigned this Jun 16, 2020
jpacik
jpacik approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@jpacik jpacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ethanyzhang ethanyzhang removed the request for review from adrian-thurston June 16, 2020 21:57
@ethanyzhang ethanyzhang merged commit 95d97c6 into master Jun 17, 2020
@ethanyzhang ethanyzhang deleted the feat/first-last-pushdown-rule branch June 17, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpacik jpacik jpacik approved these changes

@jacobmarble jacobmarble jacobmarble approved these changes

Assignees

@ethanyzhang ethanyzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethanyzhang @jacobmarble @jpacik