refactor(http): Extract write handler logic for re-use elsewhere #18507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
approved these changes
Jun 15, 2020
Comment on lines
+212
to
+211
| WithParserOptions( | ||
| models.WithParserMaxBytes(b.WriteParserMaxBytes), | ||
| models.WithParserMaxLines(b.WriteParserMaxLines), | ||
| models.WithParserMaxValues(b.WriteParserMaxValues), | ||
| ), |
brettbuddin
force-pushed
the
bb/extract-write-logic
branch
from
c4ce13a to
cb8d38d
Compare
brettbuddin
force-pushed
the
bb/extract-write-logic
branch
from
cb8d38d to
e1f063c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a 3-part story to deliver an API for 1.x writes.
This shuffles the structure of the existing
/api/v2/writeendpoint to allow the/write(1.x) endpoint to share the point parse and writing code. Code that was originally placed directly in the main HTTP handler has been moved out into other supporting structures for re-use.📎 influxdata/idpe#6948