Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): register bare aggregate #18419

Merged
merged 1 commit into from
Jun 9, 2020
Merged

feat(query): register bare aggregate #18419

merged 1 commit into from
Jun 9, 2020

Conversation

fchikwekwe
Copy link
Contributor

@fchikwekwe fchikwekwe commented Jun 9, 2020 •
edited
Loading

This PR enables the PushDownBareAggregateRule and adds testing to cover count() as a bare aggregate.

It also makes a small fix to PushDownBareAggregateRule.Name().

@fchikwekwe fchikwekwe force-pushed the feat/register-bare-agg-pushdown branch 2 times, most recently from cb745b5 to 67c1ca5 Compare June 9, 2020 21:23
@fchikwekwe fchikwekwe force-pushed the feat/register-bare-agg-pushdown branch from 67c1ca5 to 1bf2ce1 Compare June 9, 2020 21:25
@fchikwekwe fchikwekwe requested review from a team and wolffcm and removed request for a team June 9, 2020 21:57
wolffcm
wolffcm approved these changes Jun 9, 2020
View reviewed changes
Copy link

@wolffcm wolffcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fchikwekwe fchikwekwe merged commit 1dac8c5 into master Jun 9, 2020
@fchikwekwe fchikwekwe deleted the feat/register-bare-agg-pushdown branch June 9, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolffcm wolffcm wolffcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchikwekwe @wolffcm