Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notebooks): make panels focusable #18233

Merged
merged 9 commits into from
May 27, 2020
Merged

feat(notebooks): make panels focusable #18233

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bdf88bd
feat: make panels click to focus instead of hover
alexpaxton May 26, 2020
eb9e3ed
chore: prettier
alexpaxton May 26, 2020
a5712a4
fix: prevent event bubbling from move panel button
alexpaxton May 26, 2020
caa6f59
Merge branch 'master' into notebooks/focusable-panels
alexpaxton May 26, 2020
e332084
feat: add title attributes to notebook panel buttons
alexpaxton May 27, 2020
594ba6d
refactor: change default cell name to "Cell"
alexpaxton May 27, 2020
fee3350
refactor: show panel buttons on hover and focus state
alexpaxton May 27, 2020
9266bb5
refactor: wrap updatePanelFocus in useCallback
alexpaxton May 27, 2020
cd1e8b3
Merge branch 'master' into notebooks/focusable-panels
alexpaxton May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: prettier
  • Loading branch information
@alexpaxton
alexpaxton committed May 26, 2020
commit eb9e3ed8f15251cfe3a9e3aba755c70ea962e3b3
17 changes: 9 additions & 8 deletions ui/src/notebooks/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import "@influxdata/clockface/dist/variables.scss";
@import '@influxdata/clockface/dist/variables.scss';

$notebook-header-height: 46px;
$notebook-size-toggle: 16px;
Expand Down Expand Up @@ -123,7 +123,8 @@ $notebook-divider-height: ($cf-marg-a * 2) + $cf-border;
left: 50%;
transform: translate(-50%, -50%);
width: $notebook-size-toggle;
transition: height 0.25s cubic-bezier(0.25, 1, 0.5, 1), border-color 0.25s ease;
transition: height 0.25s cubic-bezier(0.25, 1, 0.5, 1),
border-color 0.25s ease;
border: $cf-border solid $g8-storm;
border-radius: $cf-radius / 2;
}
Expand Down Expand Up @@ -221,11 +222,11 @@ $notebook-divider-height: ($cf-marg-a * 2) + $cf-border;
}

.notebook-header--buttons {
display: inline-flex;
flex: 0 0 auto;
flex-wrap: wrap;
display: inline-flex;
flex: 0 0 auto;
flex-wrap: wrap;

> * {
margin-left: 4px;
}
> * {
margin-left: 4px;
}
}