Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change "Submit" to "Run Notebook" #18230

Merged
merged 2 commits into from
May 26, 2020
Merged

feat: change "Submit" to "Run Notebook" #18230

merged 2 commits into from
May 26, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented May 26, 2020 •
edited
Loading

Screen Shot 2020-05-26 at 2 26 40 PM

Making the button match the design without disrupting the Time Machine

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from drdelambre May 26, 2020 21:31
@alexpaxton alexpaxton merged commit dae7953 into master May 26, 2020
@alexpaxton alexpaxton deleted the notebooks/submit-button branch May 26, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @drdelambre