Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification/telegram): add telegram notification #18218

Merged
merged 9 commits into from
Jul 25, 2020
Merged

feat(notification/telegram): add telegram notification #18218

merged 9 commits into from
Jul 25, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented May 26, 2020 •
edited
Loading

Closes #17899

This PR adds telegram notification endpoint and notification rules. It depends on influxdata/flux#2857 that introduces a new telegram package to send notifications.

What is in this PR

  • implementation and tests of telegram endpoint and rule
  • swagger updated with telegram notification rule and endpoint
  • updated UI to use the new swagger + new UI for telegram endpoint and rule:
    • Create/Edit Telegram Notification Endpoint
      image
    • Create/Edit Telegram Notification Rule
      image
  • note that telegram default message template wraps variables into `preformatted text` to prevent telegram markdown errors

What is not in this PR

  • telegram endpoint and rule in =pkger=
  • new UI tests

@sranka sranka changed the title 17899/telegram notification feat(notification/telegram): add telegram notification May 26, 2020
@russorat russorat requested a review from desa June 8, 2020 18:23
@sranka sranka force-pushed the 17899/telegramNotification branch 3 times, most recently from 29039d4 to 11ae0dc Compare July 9, 2020 12:30
@sranka sranka marked this pull request as ready for review July 9, 2020 15:47
@sranka sranka requested a review from a team as a code owner July 9, 2020 15:47
@sranka sranka mentioned this pull request Jul 10, 2020
Closed
7 tasks
@sanderson sanderson mentioned this pull request Jul 10, 2020
Open
2 tasks
@desa desa requested a review from ebb-tide July 21, 2020 22:15
@sranka sranka force-pushed the 17899/telegramNotification branch from e33375e to 218841e Compare July 23, 2020 12:36
ebb-tide
ebb-tide approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @sranka

notification/endpoint/endpoint_test.go Show resolved Hide resolved
ui/src/notifications/endpoints/components/EndpointCards.tsx
@@ -57,7 +57,7 @@ const EmptyEndpointList: FC<{searchTerm: string}> = ({searchTerm}) => {
<EmptyState.Text>
Want to send notifications to Slack,
<br />
PagerDuty or an HTTP server?
PagerDuty, Telegram or an HTTP server?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ui/src/notifications/rules/components/TelegramMessage.tsx
/>
</Form.Element>
/*
// keep it simple, the following elements are possible, but too advanced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds wise

@sranka sranka force-pushed the 17899/telegramNotification branch from 066c26f to bd8db8e Compare July 25, 2020 10:00
@sranka sranka mentioned this pull request Jul 25, 2020
Closed
@sranka sranka merged commit 5603c02 into master Jul 25, 2020
@sranka sranka deleted the 17899/telegramNotification branch July 25, 2020 10:13
@desa desa mentioned this pull request Jul 27, 2020
Merged
@sranka sranka restored the 17899/telegramNotification branch July 29, 2020 11:26
@sranka sranka mentioned this pull request Jul 29, 2020
Merged
7 tasks
@jacobmarble jacobmarble deleted the 17899/telegramNotification branch January 2, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebb-tide ebb-tide ebb-tide approved these changes

@desa desa Awaiting requested review from desa

@121watts 121watts Awaiting requested review from 121watts

@jsteenb2 jsteenb2 Awaiting requested review from jsteenb2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InfluxDB v2 - Telegram - Notification Endpoint
2 participants
@sranka @ebb-tide