feat: allow monaco to autogrow #18205
Conversation
| @@ -0,0 +1,39 @@ | |||
| const MIN_HEIGHT = 100 | |||
There was a problem hiding this comment.
not global, it's scoped to the module instance. usually if you chose an arbitrary number in your code, you can expect it to change for arbitrary reasons. pulling it out as a constant at the top of a module signals "this is a compile time configuration" and makes it easier to change when the time comes without searching through all the app logic thinking "which one of these 100s corresponded to that change?" and consolidating them in to logical groups if you have multiple instances
drdelambre
requested review from
a team and
asalem1
and removed request for
a team
|
|
||
| if (prevHeight !== Math.max(MIN_HEIGHT, height)) { | ||
| prevHeight = Math.max(MIN_HEIGHT, height) | ||
| editorElement.style.height = `${height}px` |
There was a problem hiding this comment.
should this be setting the height to the reassigned prevHeight? It doesn't seem like we're using prevHeight anywhere else
There was a problem hiding this comment.
you're probably right. lemme double check
This allows monaco to grow to whatever hight it wants to fill the content, allowing interfaces that grow vertically. Removes minimap and the scrollbar as well, as they dont make sense when you can't scroll