Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hb_parse_error): created a JSON validation function to prevent HB error and correctly log errors #18199

Merged
merged 1 commit into from
May 22, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented May 22, 2020

Solves https://app.honeybadger.io/projects/61122/faults/64056920

Problem

Inundation by HoneyBadger errors is leading us to ignore the importance of these metrics. In some cases, a HB triggered when trying to log a different error. This can cause valid errors to go unseen and unnoticed.

Solution

This PR aims to reduce the amount of unnecessary noise generated by HB errors by fixing one of the HB errors. While this may not address the root cause of why the error was generated, it will allow for the first error to bubble up and potentially provide us with more relevant information

@asalem1 asalem1 requested review from a team, hoorayimhelping and drdelambre and removed request for a team and hoorayimhelping May 22, 2020 13:04
@asalem1 asalem1 merged commit 24ce360 into master May 22, 2020
@asalem1 asalem1 deleted the chore/hb-parse-error branch May 22, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants