chore(reduce_honeybadger_noise): saveCheckFromTimeMachine creating HoneyBadger noise #18188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Honeybadger errors when users were trying to save checks with the same name.
TCL735
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://app.honeybadger.io/projects/61122/faults/64020050
Problem
Users creating a check with a name that already exists on another check was causing us to report a HoneyBadger error. By reporting this error to HoneyBadger, we are creating extra HoneyBadger noise that isn't actionable in any way and reduces the importance of HoneyBadger errors.
Solution
Check the error message that's returned in the catch block of the saveCheckFromTimeMachine to see if there's a reference to the "rename your check" string above. If there is, don't report a HoneyBadger error.