Skip to content

fix(task/scheduler): Reuse slices built by iterator to reduce allocations #17384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2020
Merged

fix(task/scheduler): Reuse slices built by iterator to reduce allocations #17384

merged 2 commits into from
Mar 24, 2020

Conversation

brettbuddin
Copy link
Contributor

@brettbuddin brettbuddin commented Mar 23, 2020 •
edited
Loading

Reuse the the toDelete and toInsert slices within the TreeScheduler to reduce the allocation churn when creating iterators for the B-Tree ascension.

This is an intermediate step to relieve some of the memory usage. We will be going farther than this in how we handle this iterator in the upcoming TreeScheduler refactor.

📎 influxdata/idpe#6479

GeorgeMac
GeorgeMac approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@brettbuddin brettbuddin merged commit 5482cc3 into master Mar 24, 2020
@brettbuddin brettbuddin deleted the bb/reuse-slices branch March 24, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@docmerlin docmerlin docmerlin approved these changes

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettbuddin @docmerlin @GeorgeMac