Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboards): enable optional light mode for dashboards #17232

Merged
merged 33 commits into from
Mar 16, 2020
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
0e835ae
refactor(ui): distill presentation mode toggle into discreet component
alexpaxton Mar 5, 2020
ec06fc8
refactor(ui): introduce foundations for Light Mode
alexpaxton Mar 6, 2020
6390d22
fix(ui): ensure light mode does not affect dashboards index view
alexpaxton Mar 6, 2020
29c2438
feat(ui): enable light mode for some chart types
alexpaxton Mar 6, 2020
0579d78
chore(ui): Merge branch 'master' into feat/light-mode-dashboards
alexpaxton Mar 11, 2020
74a1305
refactor(ui): adapt dashboard page title to light mode
alexpaxton Mar 11, 2020
8bd2c6f
refactor(ui): polish appearance of cells in light mode
alexpaxton Mar 11, 2020
334faa0
fix(ui): make detection of dashboard viewing more resilient and precise
alexpaxton Mar 11, 2020
f88734b
fix(ui): pass in missing prop
alexpaxton Mar 11, 2020
97f5573
feat(ui): allow gauge to render as either light or dark
alexpaxton Mar 11, 2020
ee87046
fix(ui): ensure light mode of gauge is scoped to dashboard cells and …
alexpaxton Mar 11, 2020
5899b22
feat(ui): refactor table graphs to conditionally render light mode
alexpaxton Mar 12, 2020
3024d56
feat(ui): enable Heatmap graphs to render in light mode
alexpaxton Mar 12, 2020
d1e2c7b
feat(ui): enable histograms to render in light mode
alexpaxton Mar 12, 2020
98b37fb
feat(ui): enable scatterplots to render in light mode
alexpaxton Mar 12, 2020
c835454
fix(ui): remove console log
alexpaxton Mar 12, 2020
3236b83
fix(ui): update test
alexpaxton Mar 12, 2020
476c6e3
refactor: calc theme state
121watts Mar 12, 2020
a689859
fix: type
121watts Mar 12, 2020
19b0f41
refactor: fix action types
121watts Mar 12, 2020
7878bdc
chore: remove dead code
121watts Mar 12, 2020
8650db5
refactor(ui): rename props from "lightMode" to "theme"
alexpaxton Mar 12, 2020
7100d23
Merge branch 'feat/light-mode-dashboards' of github.com:influxdata/in…
alexpaxton Mar 12, 2020
4b3d201
refactor(ui): make variables control bar respond to theme
alexpaxton Mar 12, 2020
a1a1854
fix(ui): update mockState to match current appState shape
alexpaxton Mar 12, 2020
5038ec2
fix(ui): update affected tests
alexpaxton Mar 12, 2020
4c2e1b5
chore: Merge branch 'master' into feat/light-mode-dashboards
alexpaxton Mar 13, 2020
1303234
refactor(theme): remove currentPage from localStorage
121watts Mar 16, 2020
927863c
chore(ui): update changelog
alexpaxton Mar 16, 2020
ded6c4f
Merge branch 'feat/light-mode-dashboards' of github.com:influxdata/in…
alexpaxton Mar 16, 2020
345ed0c
Merge branch 'master' into feat/light-mode-dashboards
alexpaxton Mar 16, 2020
a32df78
fix(ui): update test
alexpaxton Mar 16, 2020
be16888
Merge branch 'feat/light-mode-dashboards' of github.com:influxdata/in…
alexpaxton Mar 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(ui): polish appearance of cells in light mode
  • Loading branch information
alexpaxton committed Mar 11, 2020
commit 8bd2c6ff6c0c24deb61bf25c74dce71e15444a36
50 changes: 50 additions & 0 deletions ui/src/dashboards/components/DashboardLightMode.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,24 @@
background-color: $g8-storm;
}

.cell:hover .cell--draggable:hover .cell--dot-grid,
.cell:hover .cell--draggable:hover .cell--dot-grid:before,
.cell:hover .cell--draggable:hover .cell--dot-grid:after {
background-color: $c-pool;
}

.cell--context {
color: $g13-mist;
}
.cell:hover .cell--context {
color: $g8-storm;
}
.cell:hover .cell--context:hover,
.cell .cell--context.cell--context__active,
.cell:hover .cell--context.cell--context__active {
color: $c-pool;
}

.cell--note-indicator {
color: $g13-mist;

Expand All @@ -53,4 +71,36 @@
color: $c-star;
}
}

.cell--view-empty {
color: $g11-sidewalk;
}
}

/*
Light Mode Cells
------------------------------------------------------------------------------
*/

.clockface--app-wrapper.dashboard-light-mode {
.react-resizable-handle {
border-right-color: $g14-chromium;
border-bottom-color: $g14-chromium;

&:before,
&:after {
background-color: $g20-white;
}

&:hover {
border-right-color: $c-comet;
border-bottom-color: $c-comet;
}
}
.react-grid-item.resizing .react-resizable-handle,
.react-grid-item.react-draggable-dragging .react-resizable-handle {
opacity: 1;
border-right-color: $c-comet;
border-bottom-color: $c-comet;
}
}