feat(influxdb): Backport modules to 1.7.x #17063
Conversation
|
I don't believe this should be backported to 1.7 line. According to semver this kind of change falls into a MINOR change, not a PATCH one. |
so we have a 1.7 branch that the next minor release will likely be based on. 1.7 is the tip of all 1.7.x development so if we release, for example, 1.7.11, we'd like this modules work to land there. i recognize that this isn't immediately clear. does this make sense or am i missing something? |
ayang64
force-pushed
the
backport-modules-to-1.7.x
branch
from
b40977a to
a0e7d0b
Compare
go.mod
Outdated
| @@ -3,108 +3,54 @@ module github.com/influxdata/influxdb | |||
| go 1.12 | |||
There was a problem hiding this comment.
Does this need to be updated?
There was a problem hiding this comment.
d'oh -- yes, it does.
ayang64
force-pushed
the
backport-modules-to-1.7.x
branch
from
a0e7d0b to
4d60807
Compare
Dockerfile_build_ubuntu64_go1.12
Outdated
| RUN gem install fpm | ||
|
|
||
| # setup environment | ||
| ENV GO_VERSION 1.12 |
There was a problem hiding this comment.
Does this need to be updated?
There was a problem hiding this comment.
Actually, the name of this file is Dockerfile_build_ubuntu64_go1.12 so I'm not sure if it should be changed here or a new file created??
I don't think so. The original author isn't around but as far as I can tell, it was there to test go 1.12 before it was released. I'll delete the file and resubmit the PR. |
|
Actually -- if it is okay with you, what I'd like to do is leave it in this branch. The docker file exists in our Does that sound reasonable? |
|
I'd say just remove it from this branch so we don't have to bother with a backport to remove it. |
ayang64
force-pushed
the
backport-modules-to-1.7.x
branch
from
4d60807 to
0353d34
Compare
This PR will backport the modules work done in 1.8 to the 1.7 branch.
This involves removing Gopkg.* files, adding go.mod and go.sum files, and updating the supporting CI/CD configuration and scripts.
Closes: #16901
Closes: #17057