Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update giraffe #16435

Merged
merged 2 commits into from
Jan 7, 2020
Merged

fix(ui): update giraffe #16435

merged 2 commits into from
Jan 7, 2020

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Jan 7, 2020

Closes #16395

Updates giraffe to use new logic to determine the optimal spacing of the time labels and use as many labels as d3 can fit in the time axis.

@TCL735 TCL735 requested a review from a team January 7, 2020 19:27
@ghost ghost requested review from glinton and zoesteinkamp and removed request for a team January 7, 2020 19:27
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to add to changelog! 😉

@TCL735 TCL735 merged commit dc188fc into master Jan 7, 2020
@TCL735 TCL735 deleted the fix_16395_update_giraffe branch January 7, 2020 19:52
alexpaxton pushed a commit that referenced this pull request Jan 9, 2020
* fix(ui): update giraffe

* chore: update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dates are squished to the left for graphs
2 participants