Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): remove lodash _ all #16273

Closed
wants to merge 3 commits into from
Closed

Conversation

zoesteinkamp
Copy link
Contributor

clean up complete

Closes #15694

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

clean up complete
@zoesteinkamp zoesteinkamp force-pushed the build/treeshake-lodash branch from 2a545c2 to 370b3b6 Compare December 19, 2019 01:20
@asalem1
Copy link
Contributor

asalem1 commented Dec 19, 2019

I wonder if we should incorporate this eslint-plugin so enforce these import changes so that future developers don't undo all this hard work:

https://github.com/wix/eslint-plugin-lodash

Fixing lodash install issue
@zoesteinkamp
Copy link
Contributor Author

This issue is going on hold for now, to be addressed at a later time when we have the ability to solve some of its issues.

@russorat
Copy link
Contributor

@zoesteinkamp should we close this?

@williamhbaker
Copy link
Contributor

Since we are now using the UI assets from the ui repository (#21090), I am closing this PR!

@asalem1 asalem1 deleted the build/treeshake-lodash branch April 16, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eradicate import _ from 'lodash' in favor of importing individual functions
4 participants