feat(pkger): pkger to use updated dashboard params #16142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearyhud
force-pushed
the
16121/dashboard-endpoints
branch
from
ca8c29a to
bed982b
Compare
jsteenb2
reviewed
Dec 5, 2019
jsteenb2
reviewed
Dec 5, 2019
jsteenb2
reviewed
Dec 5, 2019
jsteenb2
reviewed
Dec 5, 2019
dearyhud
force-pushed
the
16121/dashboard-endpoints
branch
2 times, most recently
from
9557cda to
2329159
Compare
jsteenb2
reviewed
Dec 5, 2019
jsteenb2
force-pushed
the
16121/dashboard-endpoints
branch
2 times, most recently
from
3c2d0c5 to
0950be0
Compare
dearyhud
force-pushed
the
16121/dashboard-endpoints
branch
from
0950be0 to
cd2857d
Compare
dearyhud
changed the title
jsteenb2
reviewed
Dec 6, 2019
| return pd | ||
| } | ||
|
|
||
| func (c *cell) toPlatform() *platform.Cell { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16142
Updates the http client to pass in the
?include=propertiesparamPkger now uses the cell view-properties param
propertiesreturned onGET /dashboards/:dashboardIDwhen cloning existing resources - no more round trip call to the API for the cell-viewPkger can now create cell view-properties in a single API call using
POST /dashboardsWell-formatted commit messages
Rebased/mergeable
Tests pass
Documentation updated or issue created (provide link to issue/pr)