Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bucket-list): wrapped DWP in featureFlag and sorted bucket list #15769

Merged
merged 7 commits into from
Nov 6, 2019

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Nov 5, 2019

Closes #15719
Closes #15720

Problem

Delete with predicate dropdown bucket list was not alphabetized

Solution

Alphabetized dropdown bucket list for delete with predicate, wrote in edge case for default system buckets and added e2e tests

alpha

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested a review from a team November 5, 2019 19:32
@ghost ghost requested review from ebb-tide and zoesteinkamp and removed request for a team November 5, 2019 19:32
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a coupla quick suggestions

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small naming nits, sorry!

ui/src/buckets/selectors/index.test.ts Outdated Show resolved Hide resolved
ui/src/buckets/selectors/index.test.ts Show resolved Hide resolved
ui/src/buckets/selectors/index.ts Outdated Show resolved Hide resolved
@asalem1 asalem1 merged commit afb4667 into master Nov 6, 2019
@asalem1 asalem1 deleted the DWP-sort-bucket branch November 8, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants