fix(tasks): replace deactivation of unrecoverable errors with metric #15430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
tasks/deactivate-errors-update
branch
from
b01d0b0 to
9794035
Compare
AlirieGray
force-pushed
the
tasks/deactivate-errors-update
branch
2 times, most recently
from
1b6d389 to
ab9039e
Compare
AlirieGray
requested review from
stuartcarnie
and removed request for
aanthony1243
stuartcarnie
approved these changes
Oct 16, 2019
AlirieGray
force-pushed
the
tasks/deactivate-errors-update
branch
from
ab9039e to
0bba4bf
Compare
AlirieGray
force-pushed
the
tasks/deactivate-errors-update
branch
from
0bba4bf to
6a0733f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comments out the deactivation logic for unrecoverable errors, to be restored when a user notification system is put in place to alert users when they have a task that is going to be deactivated.
This PR also adds a new metric for the new executor called "Unrecoverable Counter" which will allow engineers to see in one place all of the errors for which we would like to deactivate the offending tasks.
The error message "filesystem service uninitialized" is also added to the list of unrecoverable errors.