Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clientLibs): Fix up client libs page #15413

Merged
merged 9 commits into from
Oct 15, 2019
Merged

feat(clientLibs): Fix up client libs page #15413

merged 9 commits into from
Oct 15, 2019

Conversation

russorat
Copy link
Contributor

@russorat russorat commented Oct 15, 2019 •
edited
Loading

Closes #15159

Describe your proposed changes here.
image

image

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@russorat russorat changed the title WIP feat(clientLibs): Fix up client libs page feat(clientLibs): Fix up client libs page Oct 15, 2019
@drdelambre
Copy link
Contributor

run yarn test -u to update the snapshots that are failing

drdelambre
drdelambre approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good to me, this is a lot cleaner

@russorat russorat requested a review from desa October 15, 2019 20:12
sanderson
sanderson suggested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my requested changes relate to phrasing of section headings.

ui/src/clientLibraries/components/ClientCSharpOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientCSharpOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientCSharpOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientCSharpOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientCSharpOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientPythonOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientPythonOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientPythonOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientPythonOverlay.tsx Outdated Show resolved Hide resolved
ui/src/clientLibraries/components/ClientPythonOverlay.tsx Outdated Show resolved Hide resolved
@russorat russorat requested a review from sanderson October 15, 2019 23:01
sanderson
sanderson approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@russorat russorat merged commit a947a4e into master Oct 15, 2019
@russorat russorat deleted the feat/add-client-libs branch October 15, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderson sanderson sanderson approved these changes

@drdelambre drdelambre drdelambre approved these changes

@bednar bednar Awaiting requested review from bednar

@alexpaxton alexpaxton Awaiting requested review from alexpaxton

@desa desa Awaiting requested review from desa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

for each client library, show an example of setting up the client, writing data, and a link to the github repo
3 participants
@russorat @drdelambre @sanderson