Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): update check builder design #15040

Merged
merged 6 commits into from
Sep 6, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 6, 2019

Closes #15023
Closes #14955

  • Remove the matching rules card (@russorat says it doesn't work and is not critical for next week)
    • I did not delete the component for this in case we want to add it back in after launch
  • Move Status Message Template into its own card and add some documentation
  • Cards in check builder stretch to fill the screen width, but also have minimum sizes to avoid being squished on smaller screens

Screen Shot 2019-09-06 at 3 45 00 PM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team September 6, 2019 22:47
@ghost ghost requested review from ebb-tide and removed request for a team September 6, 2019 22:47
@alexpaxton alexpaxton requested review from a team and removed request for ebb-tide September 6, 2019 22:50
@ghost ghost requested review from ebb-tide and removed request for a team September 6, 2019 22:50
@alexpaxton alexpaxton removed the request for review from ebb-tide September 6, 2019 22:51
</BuilderCard.Body>
</BuilderCard>
<div className="builder-card--list alert-builder--list">
<CheckMetaCard />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Contributor

@nisley nisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned that it is very hard to know which rule matches. One mitigation is we simplified the tag matching to explicit ==

We should work on visualizing matches after launch, but I agree on approving this for GA launch.

@alexpaxton alexpaxton merged commit f2aff59 into master Sep 6, 2019
@alexpaxton alexpaxton deleted the refactor/check-builder-design branch September 6, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants