Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): improve first time alerting experience #14917

Merged
merged 13 commits into from
Sep 4, 2019
Merged

refactor(ui): improve first time alerting experience #14917

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0526196
refactor(ui): move QuestionMarkTooltip into shared folder
alexpaxton Sep 3, 2019
8310d03
refactor(ui): delete unused component
alexpaxton Sep 3, 2019
5bc6f88
refactor(ui): allow QuestionMarkTooltip to wrap other elements
alexpaxton Sep 3, 2019
d6f553d
refactor(ui): Add question mark tooltips to alerting column headers
alexpaxton Sep 3, 2019
2ca9503
refactor(ui): color code buttons to indicate importance and grouping
alexpaxton Sep 3, 2019
a76bea4
refactor(ui): swap order of endpoints and rules columns
alexpaxton Sep 3, 2019
095c579
refactor(ui): show "first time" widget when no alerting resources exist
alexpaxton Sep 3, 2019
d27a58d
refactor(ui): update alerting empty copy
alexpaxton Sep 3, 2019
504c567
refactor(ui): ensure onboarding tooltips are using the correct prop n…
alexpaxton Sep 3, 2019
2dbfcbe
refactor(ui): remove tests for tooltips in admin step
alexpaxton Sep 3, 2019
a2692f5
refactor(ui): fix affected e2e test
alexpaxton Sep 3, 2019
a1fbdf7
chore(ui): update changelog
alexpaxton Sep 3, 2019
0102b9e
Merge branch 'master' into refactor/improve-first-time-alerting-ux
alexpaxton Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(ui): remove tests for tooltips in admin step 
These should be handled by Clockface instead
  • Loading branch information
@alexpaxton
alexpaxton committed Sep 3, 2019
commit 2dbfcbe06f765bd6ed67699316c8c7df1c24b938
21 changes: 0 additions & 21 deletions ui/cypress/e2e/onboarding.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,27 +75,6 @@ describe('Onboarding', () => {
.children('.cf-button--label')
.contains('Continue')

//Check tooltips
cy.getByTestID('form-elem--orgname')
.children('[data-testid=form--label]')
.children('div.question-mark-tooltip')
.trigger('mouseenter')
.children('div[data-id=tooltip]')
.contains('An organization is')
.should($tt => {
expect($tt).to.have.class('show')
})

cy.getByTestID('form-elem--bucketname')
.children('[data-testid=form--label]')
.children('div.question-mark-tooltip')
.trigger('mouseenter')
.children('div[data-id=tooltip]')
.contains('A bucket is')
.should($tt => {
expect($tt).to.have.class('show')
})

//Input fields
cy.getByTestID('input-field--username').type(user.username)
cy.getByTestID('input-field--password').type(user.password)
Expand Down