Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks) report errors found when iterating over flux query #14287

Merged
merged 4 commits into from
Jul 11, 2019

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Jul 9, 2019

Closes #14239

This is an attempt to bubble up an error so that it fails a task appropriately.

Need help with testing and knowledge on desired task behavior.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@GeorgeMac GeorgeMac requested a review from lyondhill July 9, 2019 17:54
@GeorgeMac GeorgeMac changed the title Report errors found when iterating over flux query in task fix(tasks) report errors found when iterating over flux query Jul 10, 2019
Copy link
Contributor

@lyondhill lyondhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


// exhaustResultIterators is used to exhaust the result
// of a flux query
exhaustResultIterators func(res flux.Result) error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing? not bad.

@GeorgeMac GeorgeMac merged commit 61e35a8 into master Jul 11, 2019
@GeorgeMac GeorgeMac deleted the gm/task-result-error branch July 11, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error unknown field type despite successful task run
2 participants