Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage/reads): track memory allocations when reading from storage #12404

Merged
merged 1 commit into from
Mar 6, 2019
Merged

fix(storage/reads): track memory allocations when reading from storage #12404

merged 1 commit into from
Mar 6, 2019

Conversation

jsternberg
Copy link
Contributor

Related to influxdata/flux#1021.

wolffcm
wolffcm approved these changes Mar 6, 2019
View reviewed changes
Copy link

@wolffcm wolffcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have unit tests for these...

@jsternberg
Copy link
Contributor Author

We should definitely consider adding unit tests for storage.go. But, that currently doesn't exist so I'll try to add it in the future.

@jsternberg jsternberg merged commit 9549cc4 into master Mar 6, 2019
@jsternberg jsternberg deleted the fix/influxdb-reader-track-memory-allocations branch March 6, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolffcm wolffcm wolffcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsternberg @wolffcm