Skip to content

Fix TSM1 panic on reader error. #10299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

Fix TSM1 panic on reader error. #10299

merged 1 commit into from
Oct 10, 2018

Conversation

benbjohnson
Copy link
Contributor

This commit fixes an error check so that a nil TSM reader does
not cause a panic. Fixes #10244.

@benbjohnson
Fix TSM1 panic on reader error.
da2dfa4 
This commit fixes an error check so that a `nil` TSM reader does
not cause a panic.
@benbjohnson benbjohnson added this to the 1.7 milestone Sep 24, 2018
@benbjohnson benbjohnson self-assigned this Sep 24, 2018
@benbjohnson benbjohnson requested a review from e-dard September 24, 2018 14:56
@ghost ghost added the review label Sep 24, 2018
@benbjohnson benbjohnson mentioned this pull request Sep 24, 2018
Closed
@e-dard
Copy link
Contributor

e-dard commented Sep 26, 2018 

--- PASS: TestRunCLI_ExecuteInsert (0.00s)
Unknown precision "". Please use rfc3339, h, m, s, ms, u or ns.
Connected to http://127.0.0.1:37231 version x.x
InfluxDB shell version: y.y
> panic: close of closed channel

goroutine 108 [running]:
github.com/influxdata/influxdb/cmd/influx/cli_test.TestRunCLI.func1(0xc000240380)
	/root/go/src/github.com/influxdata/influxdb/cmd/influx/cli/cli_test.go:53 +0x32
created by github.com/influxdata/influxdb/cmd/influx/cli_test.TestRunCLI
	/root/go/src/github.com/influxdata/influxdb/cmd/influx/cli/cli_test.go:52 +0x1da
FAIL	github.com/influxdata/influxdb/cmd/influx/cli	0.018s

Related?

@e-dard e-dard modified the milestones: 1.7.0, 1.6.4 Oct 8, 2018
@benbjohnson benbjohnson merged commit 844b7ef into master Oct 10, 2018
@ghost ghost removed the review label Oct 10, 2018
@benbjohnson benbjohnson deleted the bj-tsm1-panic-fix branch October 10, 2018 14:12
@benbjohnson benbjohnson mentioned this pull request Oct 10, 2018
Merged
@e-dard
Copy link
Contributor

e-dard commented Dec 17, 2018

@benbjohnson can we also backport this into 1.5 branch today?

@benbjohnson benbjohnson mentioned this pull request Dec 17, 2018
Merged
@e-dard e-dard mentioned this pull request Feb 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-dard e-dard Awaiting requested review from e-dard

Assignees

@benbjohnson benbjohnson

Labels
kind/bug needs-backport/1.5
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Influxd startup fails eventually with fatal error: runtime: address space conflict
2 participants
@benbjohnson @e-dard