Should log an error if Graphite TCP listener times out on read

[pauldix]

See this section: https://github.com/influxdb/influxdb/blob/master/services/graphite/service.go#L184-L187

If we timeout on the read, we should log the error.

[otoolep]

This requires setting the read timeout on the connection, work started #3771

[pauldix]

We had reports that they were timing out. Maybe they were actually timing out on the client side?

[pauldix]

Do we actually want to timeout the TCP connection? Not sure that we do since it's supposed to be long lived.

[otoolep]

If we got reports, it must have been a client-side thing since the TCP connections do not currently time out, and I thought that is what you're asking for.

On other servers I've written, there is a close-after-idle time (to free up resources), which is what the associated PR is about. If we don't want this, I can close the PR.

[pauldix]

probably a good idea, but we'll have to document it

On Thu, Aug 20, 2015 at 3:37 PM, otoolep notifications@github.com wrote:

If we got reports, it must have been a client-side thing since the TCP
connections do not currently time out, and I thought that is what you're
asking for.

On other servers I've written, there is an close-after-idle time (to free
up resources), which is what the associated PR is about. If we don't want
this, I can close the PR.

—
Reply to this email directly or view it on GitHub
#3739 (comment).

[otoolep]

Not sure if we want the patch in 0.9.3, it's not huge value right now and it might be better to have it soak.

[otoolep]

#3771 ready for review.

[otoolep]

We decided against implementing the timeout, so closing.