Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port rejected commits after Flux has been upgraded #19444

Closed
stuartcarnie opened this issue Aug 26, 2020 · 2 comments
Closed

Port rejected commits after Flux has been upgraded #19444

stuartcarnie opened this issue Aug 26, 2020 · 2 comments
Assignees
Labels
area/2.x OSS 2.0 related issues and PRs team/compute team/query

Comments

@stuartcarnie
Copy link
Contributor

What

Certain commits were rejected as they are incompatible with Flux 0.66 or the 1.x storage engine.

These will need to be evaluated as to whether they will need to be ported again. The conflicts that require the latest Flux will be dependent on #19302.

revert(tasks): Revert fix(task/executor): Use correct name for last success time extern (#19435) via fde2129 cc/ @brettbuddin
revert(tasks): Revert feat(task): Inject Task's LatestSuccess Timestamp In Flux Extern (#19402) via 1ae2541 cc/ @brettbuddin
revert(flux): Revert feat: flux query profiler (#19359) via 6f805cb cc/ @yzhang1991
revert(flux): Revert Flux v0.82 upgrade via df41d42 cc/ @rockstar
revert(storage): Revert feat(influxql): Implement DELETE & DROP MEASUREMENT 1501351 cc/ @benbjohnson
revert(query): Revert feat: allow a metadata key to be required for a query to be logged (#19200) via 08cfb3f cc/ @adrian-thurston
revert(flux): Revert feat(query/stdlib): add min and max to ReadGroup (#19158) via d48dc69 cc/ @fchikwekwe

@stuartcarnie stuartcarnie added area/2.x OSS 2.0 related issues and PRs team/compute team/query labels Aug 26, 2020
@brettbuddin brettbuddin self-assigned this Aug 26, 2020
@brettbuddin brettbuddin added this to the Sprint 20-Q3-5 milestone Aug 26, 2020
@wolffcm
Copy link

wolffcm commented Sep 8, 2020

Let's treat this as a checklist. Once we've upgraded Flux in OSS, let's make sure that all of these commits have been reapplied.

It seems like there will be build issues, etc, that mean all of these are needed for the upgrade.

Also, make sure that skipped tests are re-enabled.

@wolffcm wolffcm self-assigned this Sep 9, 2020
@stuartcarnie
Copy link
Contributor Author

Closed #19569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/2.x OSS 2.0 related issues and PRs team/compute team/query
Projects
None yet
Development

No branches or pull requests

4 participants