feat(task): Inject Task's LatestSuccess Timestamp In Flux Extern #19402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettbuddin
force-pushed
the
bb/task-extern
branch
from
e49973b to
9d323a1
Compare
brettbuddin
force-pushed
the
bb/task-extern
branch
from
9d323a1 to
9b93f82
Compare
GeorgeMac
approved these changes
Aug 25, 2020
brettbuddin
force-pushed
the
bb/task-extern
branch
from
41bfba5 to
c8d4200
Compare
wolffcm
pushed a commit
that referenced
this pull request
Sep 11, 2020
Inject Task's LatestSuccess Timestamp In Flux Extern (#19402) * feat(task): Inject latest success/failure into extern. * chore(task/backend): Don't specify an extern if there are no statements. * chore(task/executor): Don't apply the latest failure for now. * chore(changelog): Add 19402 to changelog. * chore(kit): Introduce feature flag for time injection. * chore(task/executor): Guard injection into extern by feature flag. * chore(task/executor): No need for this subtest pattern. * chore(task/executor): Add tests for extern injection.
wolffcm
pushed a commit
that referenced
this pull request
Sep 16, 2020
Inject Task's LatestSuccess Timestamp In Flux Extern (#19402) * feat(task): Inject latest success/failure into extern. * chore(task/backend): Don't specify an extern if there are no statements. * chore(task/executor): Don't apply the latest failure for now. * chore(changelog): Add 19402 to changelog. * chore(kit): Introduce feature flag for time injection. * chore(task/executor): Guard injection into extern by feature flag. * chore(task/executor): No need for this subtest pattern. * chore(task/executor): Add tests for extern injection.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of influxdata/flux#3080
Continuation of #19390
Now that we're recording these timestamps, use them in the Task executor by injecting them as part of the Flux
Extern. This sets theoption tasks.latestSuccessTime = ...option on the query so that it can be used by some new APIs we're working on.Will need to be rebased once #19390 is merged.