Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date weirdness in dashboard view #15808

Closed
desa opened this issue Nov 8, 2019 · 7 comments · Fixed by #16077
Closed

Date weirdness in dashboard view #15808

desa opened this issue Nov 8, 2019 · 7 comments · Fixed by #16077
Assignees
Labels

Comments

@desa
Copy link
Contributor

desa commented Nov 8, 2019

Notice how the date strings overlap in the lower left cell
Screenshot 2019-11-08 10 27 27

When toggling between UTC and Local for their timezone, undefined shows up in dashboard view
Screenshot 2019-11-08 at 13 09 59

@desa desa added the kind/bug label Nov 8, 2019
@desa desa changed the title Dates overlap in dashboard vew Date weirdness in dashboard view Nov 8, 2019
@desa
Copy link
Contributor Author

desa commented Nov 8, 2019

Grouped these issues together because they felt related. If they aren't, we can break them apart.

@desa
Copy link
Contributor Author

desa commented Nov 8, 2019

cc @deanasheehan

@asalem1 asalem1 self-assigned this Nov 8, 2019
@asalem1
Copy link
Contributor

asalem1 commented Nov 11, 2019

@desa I can't seem to recreate the undefined issue pictured above. Do you happen to have any details on how to reproduce the bug / when the issue was reported? A similar issue appears to have taken place in one of giraffe's dependencies:

zapier/intl-dateformat#4

But that seems to have been resolved a couple of months ago when the dependency was upgraded to 0.1.1

@desa
Copy link
Contributor Author

desa commented Nov 11, 2019

@asalem1 it's very likely that we have an older version clockface in the cluster where this was discovered. I'll try updating the cluster to use the latest version the UI.

@desa
Copy link
Contributor Author

desa commented Nov 12, 2019

@deanasheehan can you confirm whether you still see undefined in the frankfurt cluster when you toggle the timezone.

@asalem1
Copy link
Contributor

asalem1 commented Nov 14, 2019

Apparently, the undefined error is reproducible by switching to a new language where the time is then formatted to 24h rather than AM/PM :

Screen Shot 2019-11-14 at 12 50 01 PM

@asalem1
Copy link
Contributor

asalem1 commented Nov 18, 2019

Fixed the undefined error in this PR:

influxdata/giraffe#116

Need to publish a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants