feat(ui): add positioning option to line graphs #16077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
reviewed
Dec 2, 2019
TCL735
force-pushed
the
feat_15836_add_stacked_line_layer
branch
from
fd10792 to
d399119
Compare
hoorayimhelping
approved these changes
Dec 2, 2019
asalem1
approved these changes
Dec 3, 2019
asalem1
reviewed
Dec 3, 2019
|
There is an issue that needs to resolved: user selection of line position does not persist when cell is saved into a dashboard, and then the cell is viewed in the dashboard. Line position selection is empty and graph defaults to "overlaid" even when "stacked" was selected prior to saving. |
Yes, not giving a position (undefined) is handled through TypeScript. We have an interface that says position is optional. At compile time, TypeScript will convert to JavaScript with the necessary properties (with undefined values for optional properties) The behavior of line graphs without a position property is "overlaid" |
TCL735
force-pushed
the
feat_15836_add_stacked_line_layer
branch
2 times, most recently
from
abee34f to
3d2e2bb
Compare
TCL735
force-pushed
the
feat_15836_add_stacked_line_layer
branch
from
3d2e2bb to
a0a8b83
Compare
TCL735
force-pushed
the
feat_15836_add_stacked_line_layer
branch
from
a0a8b83 to
596a7a0
Compare
jsteenb2
reviewed
Dec 3, 2019
…line plus stat charts
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15836
Closes #15808
Add dropdown menu for line positioning in graphs to allow for stacked line graphs.