fix: tests should pass now

deleted tests for dead code

removed a test runner for the variable service from http - doesn't really make sense to run it from there

http/variable_test.go

@@ -14,7 +14,6 @@ import (
 	"go.uber.org/zap"
 
 	platform "github.com/influxdata/influxdb"
-	"github.com/influxdata/influxdb/inmem"
 	"github.com/influxdata/influxdb/mock"
 	platformtesting "github.com/influxdata/influxdb/testing"
 	"github.com/julienschmidt/httprouter"
@@ -887,37 +886,3 @@ func TestService_handlePostVariableLabel(t *testing.T) {
 		})
 	}
 }
-
-func initVariableService(f platformtesting.VariableFields, t *testing.T) (platform.VariableService, string, func()) {
-	t.Helper()
-
-	svc := inmem.NewService()
-	svc.IDGenerator = f.IDGenerator
-	svc.TimeGenerator = f.TimeGenerator
-	if f.TimeGenerator == nil {
-		svc.TimeGenerator = platform.RealTimeGenerator{}
-	}
-
-	ctx := context.Background()
-	for _, variable := range f.Variables {
-		if err := svc.ReplaceVariable(ctx, variable); err != nil {
-			t.Fatalf("failed to populate variables")
-		}
-	}
-
-	variableBackend := NewMockVariableBackend()
-	variableBackend.HTTPErrorHandler = ErrorHandler(0)
-	variableBackend.VariableService = svc
-	handler := NewVariableHandler(variableBackend)
-	server := httptest.NewServer(handler)
-	client := VariableService{
-		Addr: server.URL,
-	}
-	done := server.Close
-
-	return &client, inmem.OpPrefix, done
-}
-
-func TestVariableService(t *testing.T) {
-	platformtesting.VariableService(initVariableService, t)
-}

testing/variable.go

@@ -228,7 +228,7 @@ func CreateVariable(init func(VariableFields, *testing.T) (platform.VariableServ
 				Variables: []*platform.Variable{
 					{
 						ID:             MustIDBase16(idB),
-						OrganizationID: platform.ID(3),
+						OrganizationID: MustIDBase16(idD),
 						Name:           "existing-variable",
 						Selected:       []string{"b"},
 						Arguments: &platform.VariableArguments{
@@ -241,7 +241,7 @@ func CreateVariable(init func(VariableFields, *testing.T) (platform.VariableServ
 			args: args{
 				variable: &platform.Variable{
 					ID:             MustIDBase16(idA),
-					OrganizationID: platform.ID(3),
+					OrganizationID: MustIDBase16(idD),
 					Name:           "existing-variable",
 					Selected:       []string{"a"},
 					Arguments: &platform.VariableArguments{
@@ -262,7 +262,7 @@ func CreateVariable(init func(VariableFields, *testing.T) (platform.VariableServ
 				variables: []*platform.Variable{
 					{
 						ID:             MustIDBase16(idB),
-						OrganizationID: platform.ID(3),
+						OrganizationID: MustIDBase16(idD),
 						Name:           "existing-variable",
 						Selected:       []string{"b"},
 						Arguments: &platform.VariableArguments{