Skip to content

feat: add possibility to configure proxy and redirects #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 13, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 9, 2021

Proposed Changes

  1. Added possibility to configure proxy via connectionProxyDictionary option.
  2. Added possibility to configure redirect via urlSessionDelegate option.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • swift test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #38 (f1f0b72) into master (79333a1) will increase coverage by 34.82%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #38       +/-   ##
===========================================
+ Coverage   52.56%   87.39%   +34.82%     
===========================================
  Files         135       10      -125     
  Lines        6120      706     -5414     
===========================================
- Hits         3217      617     -2600     
+ Misses       2903       89     -2814     
Impacted Files Coverage Δ
Sources/InfluxDBSwift/InfluxDBClient.swift 79.61% <87.50%> (+0.23%) ⬆️
...InfluxDBSwiftApis/Generated/JSONDataEncoding.swift
Tests/InfluxDBSwiftApisTests/SecretsAPITests.swift
...InfluxDBSwiftApis/Generated/Models/TaskLinks.swift
...fluxDBSwiftApis/Generated/Models/BucketLinks.swift
...s/InfluxDBSwiftApis/Generated/Models/Buckets.swift
...rces/InfluxDBSwiftApis/Generated/Models/User.swift
...enerated/Models/AddResourceMemberRequestBody.swift
Tests/InfluxDBSwiftApisTests/SetupAPITests.swift
...xDBSwiftApis/Generated/Models/Authorizations.swift
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79333a1...f1f0b72. Read the comment docs.

@bednar bednar changed the title feat: add possibility to configure proxy feat: add possibility to configure proxy and redirects Sep 9, 2021
@bednar bednar marked this pull request as ready for review September 9, 2021 19:07
@bednar bednar requested a review from rhajek September 9, 2021 19:08
@bednar bednar merged commit 4a05882 into master Sep 13, 2021
@bednar bednar deleted the feat/proxy-redirects branch September 13, 2021 08:26
@bednar bednar added this to the 0.7.0 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants