Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backslash escaping in serialization to Line protocol #303

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Aug 13, 2021

Closes #302

Proposed Changes

The backslash does not have to be escaped in Measurement, Tag key, Tag value and Field key. For more info see:

https://docs.influxdata.com/influxdb/cloud/reference/syntax/line-protocol/#special-characters

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #303 (24b0b0d) into master (cf21862) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          27       27           
  Lines        2189     2189           
=======================================
  Hits         2028     2028           
  Misses        161      161           
Impacted Files Coverage Δ
influxdb_client/client/write/point.py 99.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf21862...24b0b0d. Read the comment docs.

@bednar bednar requested a review from rhajek August 13, 2021 06:16
@bednar bednar marked this pull request as ready for review August 13, 2021 06:16
@bednar bednar merged commit ad58f9e into master Aug 16, 2021
@bednar bednar deleted the fix/escaping_backslash branch August 16, 2021 11:08
@bednar bednar added this to the 1.20.0 milestone Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-escaping the \ character when converting to line protocol
3 participants