Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write a dictionary-style object without tags #235

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 23, 2021

Closes #234

Proposed Changes

Added a default empty dict for tags in dictionary-style object.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #235 (da97bca) into master (5f3ce1f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files          25       25           
  Lines        2003     2004    +1     
=======================================
+ Hits         1838     1839    +1     
  Misses        165      165           
Impacted Files Coverage Δ
influxdb_client/client/write_api.py 99.05% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3ce1f...da97bca. Read the comment docs.

@bednar bednar marked this pull request as ready for review April 23, 2021 07:09
@bednar bednar requested a review from rhajek April 23, 2021 07:09
@bednar bednar merged commit 5cbc212 into master Apr 27, 2021
@bednar bednar deleted the fix/dictitonary-without-tags branch April 27, 2021 08:37
@bednar bednar added this to the 1.17.0 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle missing 'tags' key
2 participants