Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip DataFrame rows without data #170

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 25, 2020

Closes #169

Proposed Changes

Skip DataFrame rows without data - all fields are nan

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #170 (2bac660) into master (c8fd3b5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   89.42%   89.47%   +0.04%     
==========================================
  Files          26       26              
  Lines        1939     1948       +9     
==========================================
+ Hits         1734     1743       +9     
  Misses        205      205              
Impacted Files Coverage Δ
...fluxdb_client/client/write/dataframe_serializer.py 97.10% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8fd3b5...2bac660. Read the comment docs.

@bednar bednar marked this pull request as ready for review November 25, 2020 09:11
@bednar bednar requested a review from rhajek November 25, 2020 09:11
@bednar bednar merged commit ffae906 into master Nov 27, 2020
@bednar bednar deleted the fix/dataframe-rows-nan branch November 27, 2020 12:47
@bednar bednar added this to the 1.13.0 milestone Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to write Pandas Dataframe
2 participants