Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional ciso8601 #120

Merged
merged 11 commits into from
Jun 30, 2020
Merged

feat: optional ciso8601 #120

merged 11 commits into from
Jun 30, 2020

Conversation

rolincova
Copy link
Contributor

Closes #98

ciso8601 is an optional dependency and has to be installed separably

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@rolincova rolincova requested a review from bednar June 30, 2020 06:43
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #120 into master will decrease coverage by 0.02%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   88.71%   88.68%   -0.03%     
==========================================
  Files          22       23       +1     
  Lines        1808     1821      +13     
==========================================
+ Hits         1604     1615      +11     
- Misses        204      206       +2     
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
influxdb_client/client/date_utils.py 100.00% <100.00%> (ø)
influxdb_client/client/flux_csv_parser.py 91.71% <100.00%> (ø)
influxdb_client/client/write/point.py 98.30% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ddf643...5393216. Read the comment docs.

influxdb_client/client/write/point.py Outdated Show resolved Hide resolved
influxdb_client/client/flux_csv_parser.py Outdated Show resolved Hide resolved
influxdb_client/client/flux_csv_parser.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar added this to the 1.9.0 milestone Jun 30, 2020
@bednar bednar added the enhancement New feature or request label Jun 30, 2020
@bednar bednar merged commit 1bb088f into master Jun 30, 2020
@bednar bednar deleted the feat/optional-ciso branch June 30, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does the library have to require ciso8601?
3 participants