-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Fixes strings to prevent PHP 8.2 notices #140
Conversation
PHP 8.2 throws deprecation notices on this string interpolation syntax. Does not affect the environment variable syntax in the config settings. No functional changes, backward compatible with PHP 7.
Codecov ReportBase: 74.93% // Head: 74.93% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
=========================================
Coverage 74.93% 74.93%
Complexity 424 424
=========================================
Files 25 25
Lines 1093 1093
=========================================
Hits 819 819
Misses 274 274
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Please review and merge it, 8.2 is now the default version on many new project ! |
I'm a first-time-contributor, somebody from the Influx team has to trigger the CircelCI build... |
@powersj sorry for directly pinging you. Can you take a look? |
My plan is to look at this Monday. I'd like to understand why tests didn't run. Given I know next to nothing about PHP I need to see those tests run before hitting merge. Thanks! |
The tests on a PR
I have no option to do so, it says "Waiting for status to be reported". It looks like I may have already done the the codecov was reported as a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it did run, but github didn't get the results:
It looks like PHP 7.x is now EOL, but we do still do tests there so thanks for the backwards compatibility note.
@cstuder tests on master decided to fail: https://app.circleci.com/pipelines/github/influxdata/influxdb-client-php/1655/workflows/84bc58b0-f461-493c-a14d-66db691eb33f Is this a missing dependency? |
What happened, did it fix itself? :-) Anyway, thanks for the new release, looks good. |
Proposed Changes
PHP 8.2 throws deprecation notices on this string interpolation syntax. Does not affect the environment variable syntax in the config settings. No functional changes, backward compatible with PHP 7.
Checklist
make test
completes successfully