Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fixes strings to prevent PHP 8.2 notices #140

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

cstuder
Copy link
Contributor

@cstuder cstuder commented Jan 28, 2023

Proposed Changes

PHP 8.2 throws deprecation notices on this string interpolation syntax. Does not affect the environment variable syntax in the config settings. No functional changes, backward compatible with PHP 7.

Checklist

  • Rebased/mergeable
  • make test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

PHP 8.2 throws deprecation notices on this string interpolation syntax.
Does not affect the environment variable syntax in the config settings.
No functional changes, backward compatible with PHP 7.
@codecov-commenter
Copy link

Codecov Report

Base: 74.93% // Head: 74.93% // No change to project coverage 👍

Coverage data is based on head (4809291) compared to base (c8b67ba).
Patch coverage: 50.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #140   +/-   ##
=========================================
  Coverage     74.93%   74.93%           
  Complexity      424      424           
=========================================
  Files            25       25           
  Lines          1093     1093           
=========================================
  Hits            819      819           
  Misses          274      274           
Impacted Files Coverage Δ
src/InfluxDB2/InvokableScriptsApi.php 13.33% <0.00%> (ø)
src/InfluxDB2/DefaultApi.php 90.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dynamicnet
Copy link

Please review and merge it, 8.2 is now the default version on many new project !

@cstuder
Copy link
Contributor Author

cstuder commented Mar 12, 2023

I'm a first-time-contributor, somebody from the Influx team has to trigger the CircelCI build...

@ss89
Copy link

ss89 commented Mar 20, 2023

@powersj sorry for directly pinging you. Can you take a look?

@powersj
Copy link
Contributor

powersj commented Mar 24, 2023

My plan is to look at this Monday. I'd like to understand why tests didn't run. Given I know next to nothing about PHP I need to see those tests run before hitting merge.

Thanks!

@cstuder
Copy link
Contributor Author

cstuder commented Mar 27, 2023

@powersj What tests are you referring to? The Circle CI automated tests don't run because I'm a first-time-contributor and you have to manually approve them to run.

For the unit tests within this package, have a look at PR #139 first. Those should be properly dockerized now.

@powersj
Copy link
Contributor

powersj commented Mar 27, 2023

What tests are you referring to?

The tests on a PR

The Circle CI automated tests don't run because I'm a first-time-contributor and you have to manually approve them to run.

I have no option to do so, it says "Waiting for status to be reported". It looks like I may have already done the the codecov was reported as a comment.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it did run, but github didn't get the results:

https://app.circleci.com/pipelines/github/influxdata/influxdb-client-php/1595/workflows/715d1788-6488-4cd9-b635-0c70d5c256f3

It looks like PHP 7.x is now EOL, but we do still do tests there so thanks for the backwards compatibility note.

@powersj powersj merged commit d189d71 into influxdata:master Mar 27, 2023
@powersj
Copy link
Contributor

powersj commented Mar 27, 2023

@cstuder
Copy link
Contributor Author

cstuder commented Mar 30, 2023

What happened, did it fix itself? :-)

Anyway, thanks for the new release, looks good.

@bednar bednar added this to the 3.3.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants