Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Invocable scripts API #119

Merged
merged 10 commits into from
Mar 29, 2022
Merged

feat: add Invocable scripts API #119

merged 10 commits into from
Mar 29, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Mar 28, 2022

Proposed Changes

  1. Added API for InvocableScripts.
  2. Changed supported InfluxDB version from InfluxDB 2.0 to InfluxDB 2.x

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #119 (48294b0) into master (d5abfd8) will decrease coverage by 0.60%.
The diff coverage is 60.00%.

❗ Current head 48294b0 differs from pull request most recent head 0ca2694. Consider uploading reports for the commit 0ca2694 to get more accurate results

@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
- Coverage     81.83%   81.22%   -0.61%     
- Complexity      384      394      +10     
============================================
  Files            23       24       +1     
  Lines           903      911       +8     
============================================
+ Hits            739      740       +1     
- Misses          164      171       +7     
Impacted Files Coverage Δ
src/InfluxDB2/QueryApi.php 97.36% <ø> (-0.20%) ⬇️
src/InfluxDB2/InvocableScriptsApi.php 20.00% <20.00%> (ø)
src/InfluxDB2/Client.php 94.87% <100.00%> (+0.42%) ⬆️
src/InfluxDB2/FluxCsvParser.php 100.00% <100.00%> (ø)
src/InfluxDB2/HealthApi.php 100.00% <0.00%> (ø)
src/InfluxDB2/DefaultApi.php 89.58% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5abfd8...0ca2694. Read the comment docs.

@bednar bednar marked this pull request as ready for review March 28, 2022 12:37
@bednar bednar requested a review from rhajek March 28, 2022 12:37
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 013ad87 into master Mar 29, 2022
@bednar bednar deleted the invocable_scripts branch March 29, 2022 08:59
@bednar bednar added this to the 2.7.0 milestone Mar 29, 2022
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants